Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#34 - general settings #65

Merged
merged 6 commits into from
Nov 7, 2023
Merged

#34 - general settings #65

merged 6 commits into from
Nov 7, 2023

Conversation

kamilpiech97
Copy link
Member

@kamilpiech97 kamilpiech97 commented Nov 6, 2023 •
edited
Loading

This should close #34. Things like logo or colors from #34, I would do that in other issue - I think.
Added general settings where administrator can set university name, department name, teacher name, titles and email.
Added tests.

Preview:
image

@kamilpiech97 kamilpiech97 marked this pull request as ready for review November 6, 2023 13:43
@kamilpiech97 kamilpiech97 requested a review from a team as a code owner November 6, 2023 13:43
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I empty all fields in the form and click "Zapisz" and go to "Stron główna" I see blank page; dev tools say that:

image

@kamilpiech97
Copy link
Member Author

When I empty all fields in the form and click "Zapisz" and go to "Stron główna" I see blank page; dev tools say that:

image

Fixed

@kamilpiech97 kamilpiech97 mentioned this pull request Nov 7, 2023
Closed
7 tasks
@kamilpiech97 kamilpiech97 merged commit a7bfa7d into main Nov 7, 2023
3 checks passed
@kamilpiech97 kamilpiech97 deleted the #34-general-settings branch November 7, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@KarolZygadlo KarolZygadlo KarolZygadlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General settings management
3 participants
@kamilpiech97 @EwelinaSkrzypacz @KarolZygadlo